Skip to content

[DSL] Remove nullable#332

Merged
c-harding merged 3 commits intodevelopfrom
denull
Apr 16, 2020
Merged

[DSL] Remove nullable#332
c-harding merged 3 commits intodevelopfrom
denull

Conversation

@c-harding
Copy link
Copy Markdown
Contributor

@c-harding c-harding commented Apr 16, 2020 •
edited
Loading

How to reach an MVP easily: rip out features! This time it’s @nullable, as it’s missing from the Go implementation. This will live on in a revert branch: #333.

@c-harding
[DSL] Remove nullable
ec842ef 
How to reach an MVP easily: rip out features! This will live on in a revert branch soon.
@c-harding c-harding requested a review from jaylees14 as a code owner April 16, 2020 08:57
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2020 •
edited
Loading

Codecov Report

Merging #332 into develop will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #332      +/-   ##
===========================================
- Coverage    99.00%   99.00%   -0.01%     
===========================================
  Files          135      135              
  Lines         2824     2821       -3     
  Branches        45       40       -5     
===========================================
- Hits          2796     2793       -3     
  Misses          28       28
Impacted Files Coverage Δ
src/main/scala/temple/DSL/semantics/Analyzer.scala 100.00% <ø> (ø)
...rc/main/scala/temple/DSL/semantics/Validator.scala 100.00% <100.00%> (ø)
...rc/main/scala/temple/builder/DatabaseBuilder.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07b2c94...059c70c. Read the comment docs.

c-harding added a commit that referenced this pull request Apr 16, 2020
@c-harding
[DSL] Add support for a nullable annotation in SQL
4cad558 
Still need to add support in Go, which will involve treating a lot of stuff as pointers, and checking that the postgres bindings support that (how else can you set stuff to null/non-null dynamically?).

This reverts commit ec842ef on PR #332.
@c-harding c-harding mentioned this pull request Apr 16, 2020
Draft
Lewiky
Lewiky approved these changes Apr 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Lewiky Lewiky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jaylees14
jaylees14 approved these changes Apr 16, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jaylees14 jaylees14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

> /dev/null

@c-harding c-harding merged commit 10bca39 into develop Apr 16, 2020
@c-harding c-harding deleted the denull branch April 16, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lewiky Lewiky Lewiky approved these changes

@jaylees14 jaylees14 jaylees14 approved these changes

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@c-harding @Lewiky @jaylees14